| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT |
| Date: | 2024-11-19 09:14:18 |
| Message-ID: | 202411190914.m5ctbskcsi4d@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19/11/2024 01:20, Masahiko Sawada wrote:
> I realized that building test_radixtree.c with TEST_SHARED_RT fails
> because it eventually sets RT_SHMEM when #include'ing radixtree.h but
> it's missing some header files to include. I've attached a patch to
> include necessary header files in radixtree.h to make it
> self-contained.
If those includes are only needed when RT_SHMEM is defined, I suggest
they should be guarded by #ifdef RT_SHMEM, per Peter E's IWYU efforts
lately.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La rebeldía es la virtud original del hombre" (Arthur Schopenhauer)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2024-11-19 09:20:13 | Re: tab_complete for copy(merge |
| Previous Message | Zhijie Hou (Fujitsu) | 2024-11-19 09:12:29 | RE: Disallow UPDATE/DELETE on table with unpublished generated column as REPLICA IDENTITY |