| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix an error while building test_radixtree.c with TEST_SHARED_RT |
| Date: | 2024-11-19 00:50:09 |
| Message-ID: | 3621151.1731977409@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> writes:
> On Mon, Nov 18, 2024 at 3:41 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
>> While we're at it, I noticed that lib/radixtree.h includes "postgres.h".
>> That's against our usual convention.
> Good catch. I've updated the patch accordingly.
Probably out of scope for this particular patch, but it occurred to me
to grep for other similar violations, and I found three:
src/bin/pg_combinebackup/copy_file.h:#include "c.h"
src/include/fe_utils/option_utils.h:#include "postgres_fe.h"
src/include/fe_utils/query_utils.h:#include "postgres_fe.h"
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-11-19 00:52:08 | Re: Making error message more user-friendly with spaces in a URI |
| Previous Message | Michael Paquier | 2024-11-19 00:29:27 | Re: Making error message more user-friendly with spaces in a URI |