| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Missing deconstruct_array_builtin usage |
| Date: | 2024-10-14 16:55:24 |
| Message-ID: | CAD21AoAm=mAh2o=MEN+vS=gRMakjxhVTsbV+q8cC4HbScU-OfQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 14, 2024 at 3:05 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 14.10.24 08:12, Bertrand Drouvot wrote:
> >> It seems that src/backend/utils/adt/float.c file still has functions
> >> that can use [de]construct_array_builtin(), for example
> >> float8_combine(). I think it's an oversight of d746021de1.
> > Thanks for looking at it.
> >
> > Good catch, please find attached v2 taking care of those. I looked at the
> > remaining [de]construct_array() usages and that looks ok to me.
>
> This looks good to me. I can't think of a reason why it was not
> included in the original patch.
Thank you for reviewing the patch. Pushed (v2 patch).
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2024-10-14 16:57:20 | Re: pg_upgrade check for invalid databases |
| Previous Message | Masahiko Sawada | 2024-10-14 16:54:25 | Re: Remove obsolete comment in reorderbuffer.h |