| From: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove obsolete comment in reorderbuffer.h |
| Date: | 2024-10-14 16:54:25 |
| Message-ID: | CAD21AoB-_tw9icM7Z3Hvpjx2x5BS3ZRoYcNyZ0Khdnn8361oTw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Oct 13, 2024 at 8:57 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sat, Oct 12, 2024 at 5:42 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > I realized an obsolete comment in the definition of ReorderBufferTXN.
> >
> > Commit 9fab40ad32e changed ReorderBuffer to use Slab Context for
> > allocating ReorderBufferTXN entries instead of using a caching
> > mechanism, so the txn->node is no longer used as an element of the
> > list of preallocated ReorderBufferTXNs.
> >
>
> I agree, and your patch looks good to me.
Thank you for reviewing the patch. Pushed.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-10-14 16:55:24 | Re: Missing deconstruct_array_builtin usage |
| Previous Message | Tom Lane | 2024-10-14 16:45:27 | Re: Better error reporting from extension scripts (Was: Extend ALTER OPERATOR) |