Re: Missing deconstruct_array_builtin usage

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Missing deconstruct_array_builtin usage
Date: 2024-10-14 10:05:18
Message-ID: 73e2eca8-3459-4a3e-aa85-122eda2d47e1@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 14.10.24 08:12, Bertrand Drouvot wrote:
>> It seems that src/backend/utils/adt/float.c file still has functions
>> that can use [de]construct_array_builtin(), for example
>> float8_combine(). I think it's an oversight of d746021de1.
> Thanks for looking at it.
>
> Good catch, please find attached v2 taking care of those. I looked at the
> remaining [de]construct_array() usages and that looks ok to me.

This looks good to me. I can't think of a reason why it was not
included in the original patch.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilia Evdokimov 2024-10-14 10:30:09 Re: Use function smgrclose() to replace the loop
Previous Message Jakub Wartak 2024-10-14 10:02:40 Re: allowing extensions to control planner behavior