| From: | Ilia Evdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com> |
|---|---|
| To: | Steven Niu <niushiji(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Subject: | Re: Use function smgrclose() to replace the loop |
| Date: | 2024-10-14 10:30:09 |
| Message-ID: | b4da130f-35ae-4506-b6f5-b904b7cfe20a@tantorlabs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 14.08.2024 09:32, Steven Niu wrote:
> Hi, Kirill, Junwang,
>
> I made this patch to address the refactor issue in our previous email
> discussion.
> https://www.postgresql.org/message-id/flat/CABBtG=cDTCBDCBK7McSy6bJR3s5xUTOg0vSFfuW8oLdUYyCscA(at)mail(dot)gmail(dot)com
>
>
> That is, the for loop in function smgrdestroy() and smgrdounlinkall
> can be replaced with smgrclose().
>
> for (forknum = 0; forknum <= MAX_FORKNUM; forknum++)
> smgrsw[reln->smgr_which].smgr_close(reln, forknum);
> -->
> smgrclose(rels[i]);
>
> Please let me know if you have any questions.
>
> Best Regards,
> Steven from Highgo.com
Hello,
Are you sure we can refactor loop by 'smgrclose()'? I see it is not
quite the same.
Regards,
Ilia Evdokimov,
Tantor Labs LLC.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dean Rasheed | 2024-10-14 11:03:06 | Re: Adding OLD/NEW support to RETURNING |
| Previous Message | Peter Eisentraut | 2024-10-14 10:05:18 | Re: Missing deconstruct_array_builtin usage |