| From: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | Jeff Davis <pgsql(at)j-davis(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: Adding OLD/NEW support to RETURNING |
| Date: | 2024-10-14 11:03:06 |
| Message-ID: | CAEZATCXK4zsURA7aMjbhFVd+mxo8XKm+bF1JCv6RZH7fxkXtgQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > typedef struct ReturningOption
> > {
> > NodeTag type;
> > bool isNew;
> > char *name;
> > int location;
> > } ReturningOption;
Thinking about that struct some more, I think "isNew" is better done
as an enum, since this is meant to be a generic option. So even though
it might never have more than 2 possible values, I think it's neater
done that way.
Regards,
Dean
| Attachment | Content-Type | Size |
|---|---|---|
| support-returning-old-new-v20.patch | text/x-patch | 240.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Denis Garsh | 2024-10-14 12:00:21 | Re: Add system column support to the USING clause |
| Previous Message | Ilia Evdokimov | 2024-10-14 10:30:09 | Re: Use function smgrclose() to replace the loop |