| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | Robins Tharakan <tharakan(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Date: | 2017-07-19 19:08:13 |
| Message-ID: | CAB7nPqSbdhWx4hP5eRjcieVNN-HjLh9OGAP93GxAdSA_CTukNQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 19, 2017 at 8:59 PM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
> On Wed, Jul 19, 2017 at 3:54 PM, Robins Tharakan <tharakan(at)gmail(dot)com> wrote:
>> You may want to consider this patch (attached) which additionally has the
>> pg_dumpall changes.
>> It would be great if you could help with the tests though, am unsure how
>> to go about them.
>
> You should add the properly sgml docs for this pg_dumpall change also.
Tests of pg_dump go to src/bin/pg_dump/t/ and tests for objects in
extensions are in src/test/modules/test_pg_dump, but you just care
about the former with this patch. And if you implement some new tests,
look at the other tests and base your work on that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-07-19 19:10:58 | Re: More flexible LDAP auth search filters? |
| Previous Message | Michael Paquier | 2017-07-19 19:04:09 | Re: Something for the TODO list: deprecating abstime and friends |