| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <hornschnorter(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Something for the TODO list: deprecating abstime and friends |
| Date: | 2017-07-19 19:04:09 |
| Message-ID: | CAB7nPqS=ZjG2kJ3UU4iVf907hmkks+onegKFqGF70csA-t=bXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 19, 2017 at 8:56 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wonder if it'd be worth the trouble to stick something like this into
> xlog.c:
>
> /*
> * For reliability's sake, it's critical that pg_control updates
> * be atomic writes. That generally means the active data can't
> * be more than one disk sector, which is 512 bytes on common
> * hardware. Be very careful about raising this limit.
> */
> StaticAssertStmt(sizeof(ControlFileData) <= 512,
> "pg_control is too large for atomic disk writes");
+1. Even if it just gets triggered in 20 years by some hacker, that's
a good reminder about assumptions behind the update logic.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-07-19 19:08:13 | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Previous Message | Robert Haas | 2017-07-19 19:02:44 | Re: GSoC 2017: Foreign Key Arrays |