| From: | Robins Tharakan <tharakan(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch: Add --no-comments to skip COMMENTs with pg_dump |
| Date: | 2017-07-19 19:14:18 |
| Message-ID: | CAEP4nAy+0MBJmOUA0ScyETPDo0VrBNoEb67m_+VBByi7Ajs03Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 July 2017 at 05:08, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Jul 19, 2017 at 8:59 PM,
>
> Fabrízio de Royes Mello
> > You should add the properly sgml docs for this pg_dumpall change also.
>
> Tests of pg_dump go to src/bin/pg_dump/t/ and tests for objects in
> extensions are in src/test/modules/test_pg_dump, but you just care
> about the former with this patch. And if you implement some new tests,
> look at the other tests and base your work on that.
>
Thanks Michael /
Fabrízio.
Updated patch (attached) additionally adds SGML changes for pg_dumpall.
(I'll try to work on the tests, but sending this
nonetheless
).
-
robins
| Attachment | Content-Type | Size |
|---|---|---|
| pgdump_nocomments_v3.patch | application/octet-stream | 6.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2017-07-19 19:22:16 | Re: [TRAP: FailedAssertion] causing server to crash |
| Previous Message | Robert Haas | 2017-07-19 19:10:58 | Re: More flexible LDAP auth search filters? |