Re: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: shao bret <bret(dot)shao(at)outlook(dot)com>
Cc: PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border
Date: 2017-04-11 03:05:21
Message-ID: CAB7nPqQW+kSFgh+u14coBh-+SMFELcz82ovOHnnFJ01hfSw3bw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Apr 10, 2017 at 4:02 PM, shao bret <bret(dot)shao(at)outlook(dot)com> wrote:
> I think maybe you have a little misunderstanding with my solution.

Without a proper patch it is hard to have a clear opinion in this case.

> My solution is that
> [...]
> So I think it’s easier for understanding code.
>
> What do you think?

One way or the other would be fine, at the end the last call will
likely come from Andres in CC as he is the author and committer of
replication origins. To be honest, I find the use of mul_size()
cleaner here, but that's just an opinion.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message David G. Johnston 2017-04-11 03:32:50 Re: Issues
Previous Message Michael De Marco 2017-04-11 02:43:58 Issues