答复: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border

Please help to see the patch file.
Thanks.
Bret

发送自 Windows 10 版邮件<https://go.microsoft.com/fwlink/?LinkId=550986>应用

发件人: Michael Paquier<mailto:michael(dot)paquier(at)gmail(dot)com>
发送时间: 2017年4月11日 11:05
收件人: shao bret<mailto:bret(dot)shao(at)outlook(dot)com>
抄送: PostgreSQL mailing lists<mailto:pgsql-bugs(at)postgresql(dot)org>; Andres Freund<mailto:andres(at)anarazel(dot)de>
主题: Re: 答复: [BUGS] BUG #14615: ReplicationOriginShmemInit Memory access cross-border

On Mon, Apr 10, 2017 at 4:02 PM, shao bret <bret(dot)shao(at)outlook(dot)com> wrote:
> I think maybe you have a little misunderstanding with my solution.

Without a proper patch it is hard to have a clear opinion in this case.

> My solution is that
> [...]
> So I think it’s easier for understanding code.
>
> What do you think?

One way or the other would be fine, at the end the last call will
likely come from Andres in CC as he is the author and committer of
replication origins. To be honest, I find the use of mul_size()
cleaner here, but that's just an opinion.
--
Michael