| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Sam James <sam(at)gentoo(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Build failure with GCC 15 (defaults to -std=gnu23) |
| Date: | 2024-11-27 09:27:21 |
| Message-ID: | CA+hUKGKX86B9o0sOiWdwiHf7ONhHTWtZ-pG_yJXRBa7v6doz9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Nov 18, 2024 at 2:59 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > I found a few lines we could just delete in master. I wonder if we
> > should also just require sizeof(bool) == 1 more explicitly going
> > forward with an error, since we don't have coverage or any expectation
> > of ever getting any for the alternative code AFAICS, even if it is
> > small.
>
> Yeah, that's a fair criticism. I don't think we've tested that code
> path since I retired prairiedog, so who's to say that it works even
> now? Maybe it's best to just delete that code, and if we ever find a
> new platform with wider bool, figure out what to do at that time.
Here's a draft patch for that.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Require-sizeof-bool-1.patch | application/octet-stream | 11.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | yuansong | 2024-11-27 10:53:20 | Re:Re:Re: backup server core when redo btree_xlog_insert that type is XLOG_BTREE_INSERT_POST |
| Previous Message | Thomas Munro | 2024-11-27 04:50:51 | Re: Build failure with GCC 15 (defaults to -std=gnu23) |