| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Sam James <sam(at)gentoo(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Build failure with GCC 15 (defaults to -std=gnu23) |
| Date: | 2024-11-18 01:59:23 |
| Message-ID: | 3198438.1731895163@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> I found a few lines we could just delete in master. I wonder if we
> should also just require sizeof(bool) == 1 more explicitly going
> forward with an error, since we don't have coverage or any expectation
> of ever getting any for the alternative code AFAICS, even if it is
> small.
Yeah, that's a fair criticism. I don't think we've tested that code
path since I retired prairiedog, so who's to say that it works even
now? Maybe it's best to just delete that code, and if we ever find a
new platform with wider bool, figure out what to do at that time.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-11-18 03:09:11 | Re: BUG #18710: "pg_get_viewdef" triggers assertions in special scenarios |
| Previous Message | Thomas Munro | 2024-11-18 01:30:38 | Re: Build failure with GCC 15 (defaults to -std=gnu23) |