Re: Build failure with GCC 15 (defaults to -std=gnu23)

From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Sam James <sam(at)gentoo(dot)org>, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Build failure with GCC 15 (defaults to -std=gnu23)
Date: 2024-11-18 01:30:38
Message-ID: CA+hUKGJBNYAAYE51Ef-reKo1cUDvs3GgnChyh4ETqiSVQ0MR5w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Mon, Nov 18, 2024 at 11:50 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Thomas Munro <thomas(dot)munro(at)gmail(dot)com> writes:
> > It sounds like we should stop using the old and broken
> > AC_CHECK_HEADER_STDBOOL macro.
>
> Yeah, that's what I was imagining: assume that <stdbool.h> exists
> and works, and check only to see if sizeof(bool) is acceptable.

I think this is the minimal change, which I'd push back to 13 post-freeze.

I found a few lines we could just delete in master. I wonder if we
should also just require sizeof(bool) == 1 more explicitly going
forward with an error, since we don't have coverage or any expectation
of ever getting any for the alternative code AFAICS, even if it is
small.

Attachment Content-Type Size
0001-Assume-that-stdbool.h-exists.patch text/x-patch 12.3 KB
0002-Remove-obsolete-macOS-PPC-workaround.patch text/x-patch 1.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2024-11-18 01:59:23 Re: Build failure with GCC 15 (defaults to -std=gnu23)
Previous Message Tom Lane 2024-11-17 22:50:47 Re: Build failure with GCC 15 (defaults to -std=gnu23)