| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| Date: | 2022-07-27 15:20:46 |
| Message-ID: | CA+TgmoYkRKGLTO6wDxYjOzfpXKQgwzz685iemvHUAgGr9iUhbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Jul 27, 2022 at 6:25 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Right. The whole write_relmap_file() already happens while taking
> RelationMappingLock, so that seems like a good idea for consistency at
> the end (even if I remember that there is a patch floating around to
> improve the concurrency of pgrename, which may become an easier move
> now that we require Windows 10).
>
> I have tested three runs and that was working here even if the
> issue is sporadic, so more runs may be better to have more
> confidence.
OK, I committed Thomas's patch, after taking the liberty of adding an
explanatory comment.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-27 16:00:23 | pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm. |
| Previous Message | Robert Haas | 2022-07-27 15:20:12 | pgsql: Fix read_relmap_file() concurrency on Windows. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2022-07-27 15:21:15 | Re: fairywren hung in pg_basebackup tests |
| Previous Message | Tom Lane | 2022-07-27 15:16:46 | Re: autoprewarm worker failing to load |