Re: autoprewarm worker failing to load

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robins Tharakan <tharakan(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: autoprewarm worker failing to load
Date: 2022-07-27 15:16:46
Message-ID: 2896463.1658935006@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robins Tharakan <tharakan(at)gmail(dot)com> writes:
> 089480c077056 seems to have broken pg_prewarm.

Ugh ... sure would be nice if contrib/pg_prewarm had some regression
tests.

> Checking pg_prewarm.so the function 'autoprewarm_main' visibility
> switched from GLOBAL to LOCAL. Per [1], using PGDLLEXPORT
> makes it GLOBAL again, which appears to fix the issue:

Right, that's the appropriate fix. I suppose we had better look
at everything else that's passed to bgw_function_name anywhere,
too.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-07-27 15:20:46 Re: pgsql: Remove the restriction that the relmap must be 512 bytes.
Previous Message Tom Lane 2022-07-27 14:58:44 Re: fairywren hung in pg_basebackup tests