| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add missing PGDLLEXPORT markings in contrib/pg_prewarm. |
| Date: | 2022-07-27 16:00:23 |
| Message-ID: | E1oGjSQ-001VPn-8s@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add missing PGDLLEXPORT markings in contrib/pg_prewarm.
After commit 089480c07, it's necessary for background worker entry
points to be marked PGDLLEXPORT, else they aren't findable by
LookupBackgroundWorkerFunction(). Since pg_prewarm lacks any
regression tests, it's not surprising its worker entry points were
overlooked. (A quick search turned up no other such oversights.)
I added some documentation pointing out the need for this, too.
Robins Tharakan and Tom Lane
CAEP4nAzndnQv3-1QKb=D-hLoK3Rko12HHMFHHtdj2GQAUXO3gw(at)mail(dot)gmail(dot)com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/03361a368e7bf909283cc7721af004317fdabd3d
Modified Files
--------------
contrib/pg_prewarm/autoprewarm.c | 4 ++--
doc/src/sgml/bgworker.sgml | 11 ++++++-----
2 files changed, 8 insertions(+), 7 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-07-27 17:19:39 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| Previous Message | Robert Haas | 2022-07-27 15:20:46 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |