| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| Date: | 2022-07-27 10:25:47 |
| Message-ID: | YuESq072I8cM2BDm@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Jul 27, 2022 at 06:21:07PM +1200, Thomas Munro wrote:
> Erm, let me try that again, this time with the CloseTransientFile()
> also under the lock, so that we never have a file handle without a
> lock.
Right. The whole write_relmap_file() already happens while taking
RelationMappingLock, so that seems like a good idea for consistency at
the end (even if I remember that there is a patch floating around to
improve the concurrency of pgrename, which may become an easier move
now that we require Windows 10).
I have tested three runs and that was working here even if the
issue is sporadic, so more runs may be better to have more
confidence.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-07-27 10:51:25 | pgsql: Refactor code in charge of grabbing the relations of a subscript |
| Previous Message | Thomas Munro | 2022-07-27 06:21:07 | Re: pgsql: Remove the restriction that the relmap must be 512 bytes. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melih Mutlu | 2022-07-27 10:26:10 | Re: [PATCH] Reuse Workers and Replication Slots during Logical Replication |
| Previous Message | shiy.fnst@fujitsu.com | 2022-07-27 10:08:47 | RE: Introduce wait_for_subscription_sync for TAP tests |