From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | David Binderman <dcb314(at)hotmail(dot)com> |
Cc: | "pgadmin-support(at)postgresql(dot)org" <pgadmin-support(at)postgresql(dot)org>, Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Subject: | Re: pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ? |
Date: | 2013-12-06 20:32:56 |
Message-ID: | CA+OCxoxbVSiSc2+6uWEnS0eBdeDnxh1LmYVTftW7P1CRn7XF2g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-support |
Thanks David. Guillaume, any chance you can take a look at this
please? I'm not at all familiar with that code, and I'm not entirely
sure what it's supposed to be doing.
Thanks.
On Fri, Dec 6, 2013 at 5:56 PM, David Binderman <dcb314(at)hotmail(dot)com> wrote:
> hello there,
>
> I just ran the static analyser "cppcheck" over
> the source code of pgadmin3-1.18.1. It said
> many things, including
>
> 1
>
>> [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on both sides of '!='.
>
> Source code is
>
> if(baseUkIdxSourceCol != baseUkIdxSourceCol)
>
> Suggest code rework.
>
> 2.
>
>> [dd/ddmodel/ddDBReverseEnginering.cpp:1136] -> [dd/ddmodel/ddDBReverseEnginering.cpp:1136]: (style) Same expression on both sides of '!='.
>
> Duplicate.
>
> Regards
>
> David Binderman
>
> --
> Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-support
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | David Paulo | 2013-12-08 21:30:13 | PGAdmin debugger |
Previous Message | David Binderman | 2013-12-06 17:56:57 | pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ? |