Re: pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?

On Fri, 2013-12-06 at 20:32 +0000, Dave Page wrote:
> Thanks David. Guillaume, any chance you can take a look at this
> please? I'm not at all familiar with that code, and I'm not entirely
> sure what it's supposed to be doing.
>

Sorry for the late answer. It's fixed. Thanks for the report.

> Thanks.
>
> On Fri, Dec 6, 2013 at 5:56 PM, David Binderman <dcb314(at)hotmail(dot)com> wrote:
> > hello there,
> >
> > I just ran the static analyser "cppcheck" over
> > the source code of pgadmin3-1.18.1. It said
> > many things, including
> >
> > 1
> >
> >> [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on both sides of '!='.
> >
> > Source code is
> >
> > if(baseUkIdxSourceCol != baseUkIdxSourceCol)
> >
> > Suggest code rework.
> >
> > 2.
> >
> >> [dd/ddmodel/ddDBReverseEnginering.cpp:1136] -> [dd/ddmodel/ddDBReverseEnginering.cpp:1136]: (style) Same expression on both sides of '!='.
> >
> > Duplicate.
> >
> > Regards
> >
> > David Binderman
> >
> > --
> > Sent via pgadmin-support mailing list (pgadmin-support(at)postgresql(dot)org)
> > To make changes to your subscription:
> > http://www.postgresql.org/mailpref/pgadmin-support
>
>
>

--
Guillaume
http://blog.guillaume.lelarge.info
http://www.dalibo.com