pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?

From: David Binderman <dcb314(at)hotmail(dot)com>
To: "pgadmin-support(at)postgresql(dot)org" <pgadmin-support(at)postgresql(dot)org>
Subject: pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?
Date: 2013-12-06 17:56:57
Message-ID: DUB118-W23ED3BACCC2C65ADA6A5D99CD60@phx.gbl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-support

hello there,

I just ran the static analyser "cppcheck" over
the source code of pgadmin3-1.18.1. It said
many things, including

1

> [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on both sides of '!='.

Source code is

 if(baseUkIdxSourceCol != baseUkIdxSourceCol)

Suggest code rework.

2.

> [dd/ddmodel/ddDBReverseEnginering.cpp:1136] -> [dd/ddmodel/ddDBReverseEnginering.cpp:1136]: (style) Same expression on both sides of '!='.

Duplicate.

Regards

David Binderman

Responses

Browse pgadmin-support by date

  From Date Subject
Next Message Dave Page 2013-12-06 20:32:56 Re: pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?
Previous Message Bartosz Głuszak 2013-12-05 10:19:28 pgAdmin 1.18.1: SQL query window hangs