Re: Remaining reference to _PG_fini() in ldap_password_func

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remaining reference to _PG_fini() in ldap_password_func
Date: 2024-08-20 06:59:12
Message-ID: 850a4281-fbd7-4d32-9c63-e1c6bb41e2ce@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 20/08/2024 07:46, Michael Paquier wrote:
> Hi all,
>
> While hacking on a different thing, I've noticed that
> ldap_password_func had the idea to define _PG_fini(). This is
> pointless, as library unloading is not supported in the backend, and
> something that has been cleaned up from the tree in ab02d702ef08.
> That's not something to encourage, perhaps, as well..
>
> How about removing it like in the attached to be consistent?

+1. There's also a prototype for _PG_fini() in fmgr.h, let's remove that
too.

--
Heikki Linnakangas
Neon (https://neon.tech)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2024-08-20 07:03:13 Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns
Previous Message Xiaoran Wang 2024-08-20 06:37:11 Re: Improve pg_re_throw: check if sigjmp_buf is valid and report error