| From: | Bykov Ivan <i(dot)bykov(at)modernsys(dot)ru> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Sami Imseih <samimseih(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | RE: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET |
| Date: | 2025-03-25 08:14:44 |
| Message-ID: | 538af5a9155e4206aaf7cea53db84141@localhost.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, David!
As I can see, your patch has the same idea as my v2-0001-Query-ID-Calculation-Fix-Variant-B.patch from [1].
I think it would be better to extract the jumble buffer update with hash calculation into a function
(CompressJumble in my patch). This will result in fewer changes to the source code.
We can also simply dump the null count to the buffer when we encounter a non-null field
(which will be processed in AppendJumble, indeed).
What do your thing about my patch (v2-0001-Query-ID-Calculation-Fix-Variant-B.patch)?
[1] https://www.postgresql.org/message-id/5ac172e0b77a4baba50671cd1a15285f%40localhost.localdomain
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2025-03-25 08:41:21 | Re: Cannot find a working 64-bit integer type on Illumos |
| Previous Message | Lukas Fittl | 2025-03-25 07:45:28 | Re: Proposal - Allow extensions to set a Plan Identifier |