Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Date: 2024-07-24 15:33:07
Message-ID: 4e9ef9f3-0227-45cf-a2a6-5b43ce1bd2a1@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.07.24 07:04, Michael Paquier wrote:
> This commit introduces three additional commands: \parse, \bindx and
> \close.
> \parse creates a prepared statement using extended protocol.
> \bindx binds and execute an existing prepared statement using extended
> protocol.
> \close closes an existing prepared statement using extended protocol.

This commit message confused me, because I don't think this is what the
\bindx command actually does. AFAICT, it only binds, it does not
execute. At least that is what the documentation in the content of the
patch appears to indicate.

I'm not sure \bindx is such a great name. The "x" stands for "I ran out
of ideas". ;-) Maybe \bind_named or \bindn or something like that. Or
use the existing \bind with a -name argument?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2024-07-24 15:36:21 Re: Built-in CTYPE provider
Previous Message Peter Eisentraut 2024-07-24 15:27:20 Re: Built-in CTYPE provider