Re: Built-in CTYPE provider

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Jeremy Schneider <schneider(at)ardentperf(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: Re: Built-in CTYPE provider
Date: 2024-07-24 15:27:20
Message-ID: b5a04fcd-6a67-4376-837a-60875e448a7d@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 24.07.24 17:19, Noah Misch wrote:
> On Wed, Jul 17, 2024 at 03:03:26PM -0700, Noah Misch wrote:
>> On Wed, Jul 17, 2024 at 08:48:46AM -0700, Jeff Davis wrote:
>>> On Thu, 2024-07-11 at 05:50 -0700, Noah Misch wrote:
>>>>> This is still marked as an open item for 17, but you've already
>>>>> acknowledged[1] that no code changes are necessary in version 17.
>>>>
>>>> Later posts on the thread made that obsolete.  The next step is to
>>>> settle the
>>>> question at https://postgr.es/m/20240706195129.fd@rfd.leadboat.com.
>>>> If that
>>>> conclusion entails a remedy, v17 code changes may be part of that
>>>> remedy.
>>>
>>> This is the first time you've mentioned a code change in version 17. If
>>
>> That's right.
>>
>>> you have something in mind, please propose it. However, this feature
>>> followed the right policies at the time of commit, so there would need
>>> to be a strong consensus to accept such a change.
>>
>> If I'm counting the votes right, you and Tom have voted that the feature's
>> current state is okay, and I and Laurenz have voted that it's not okay. I
>> still hope more people will vote, to avoid dealing with the tie. Daniel,
>> Peter, and Jeremy, you're all listed as reviewers on commit f69319f. Are you
>> willing to vote one way or the other on the question in
>> https://postgr.es/m/20240706195129.fd@rfd.leadboat.com?
>
> The last vote arrived 6 days ago. So far, we have votes from Jeff, Noah, Tom,
> Daniel, and Laurenz. I'll keep the voting open for another 24 hours from now
> or 36 hours after the last vote, whichever comes last. If that schedule is
> too compressed for anyone, do share.

My opinion is that it is okay to release as is.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-07-24 15:33:07 Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx
Previous Message Pavel Stehule 2024-07-24 15:19:55 Re: proposal: schema variables