| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind |
| Date: | 2024-07-25 02:19:08 |
| Message-ID: | ZqG2HAgns3nv3tFY@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 24, 2024 at 05:33:07PM +0200, Peter Eisentraut wrote:
> This commit message confused me, because I don't think this is what the
> \bindx command actually does. AFAICT, it only binds, it does not execute.
> At least that is what the documentation in the content of the patch appears
> to indicate.
Yep. FWIW, I always edit these before commit, and noticed that it was
incorrect. Just took the original message for now.
> I'm not sure \bindx is such a great name. The "x" stands for "I ran out of
> ideas". ;-) Maybe \bind_named or \bindn or something like that. Or use the
> existing \bind with a -name argument?
Not sure that I like much the additional option embedded in the
existing command; I'd rather keep a separate command for each libpq
call, that seems cleaner. So I would be OK with your suggested
\bind_named. Fine by me to be outvoted, of course.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2024-07-25 02:53:53 | Re: CI, macports, darwin version problems |
| Previous Message | Michael Paquier | 2024-07-25 01:52:13 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |