| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Maxim Orlov <orlovmg(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Japin Li <japinli(at)hotmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |
| Date: | 2024-07-25 01:52:13 |
| Message-ID: | ZqGvzSbW5TGKqZcE@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 24, 2024 at 06:00:59AM -0700, Noah Misch wrote:
> I'm still seeing need for s/int/int64/ at:
Nice catches! I've missed these.
> - "pagesegno" variable
> - return value of MultiXactIdToOffsetSegment()
Only used in four places for two elog(DEBUG1) entries with %x.
> - return value of MXOffsetToMemberSegment()
Also used in four places for two elog(DEBUG1) entries with %x, plus
three callers in PerformMembersTruncation(), nothing fancy.
> Only the first should be a live bug, since multixact isn't electing the higher
> pageno ceiling.
Yes, and it makes a switch to long segment names everywhere easier.
There is a patch in the air to do that, without the pg_upgrade
additions required to do the transfer, though.
I am attaching a patch for all these you have spotted, switching the
logs to use %llx. Does that look fine for you?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-a-couple-of-extra-spots-missing-the-int-int64-sw.patch | text/plain | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2024-07-25 02:19:08 | Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bind |
| Previous Message | Thomas Munro | 2024-07-24 23:35:46 | Re: CI, macports, darwin version problems |