Re: Built-in CTYPE provider

From: Joe Conway <mail(at)joeconway(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter(at)eisentraut(dot)org>, Jeremy Schneider <schneider(at)ardentperf(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: Re: Built-in CTYPE provider
Date: 2024-07-24 15:36:21
Message-ID: 997f001b-aafb-492e-a205-7ac1f5c95ee4@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/24/24 11:19, Noah Misch wrote:
> On Wed, Jul 17, 2024 at 03:03:26PM -0700, Noah Misch wrote:
>> On Wed, Jul 17, 2024 at 08:48:46AM -0700, Jeff Davis wrote:
>> > you have something in mind, please propose it. However, this feature
>> > followed the right policies at the time of commit, so there would need
>> > to be a strong consensus to accept such a change.
>>
>> If I'm counting the votes right, you and Tom have voted that the feature's
>> current state is okay, and I and Laurenz have voted that it's not okay. I
>> still hope more people will vote, to avoid dealing with the tie. Daniel,
>> Peter, and Jeremy, you're all listed as reviewers on commit f69319f. Are you
>> willing to vote one way or the other on the question in
>> https://postgr.es/m/20240706195129.fd@rfd.leadboat.com?
>
> The last vote arrived 6 days ago. So far, we have votes from Jeff, Noah, Tom,
> Daniel, and Laurenz. I'll keep the voting open for another 24 hours from now
> or 36 hours after the last vote, whichever comes last. If that schedule is
> too compressed for anyone, do share.

It isn't entirely clear to me exactly what we are voting on.

* If someone votes +1 (current state is ok) -- that is pretty clear.
* But if someone votes -1 (current state is not ok?) what does that mean
in practice?
- a revert?
- we hold shipping 17 until we get consensus (via some plan or
mitigation or whatever)?
- something else?

In any case, I am a hard -1 against reverting. +0.5 on "current state is
ok", and +1 on "current state is ok with agreement on what to do in 18"

--
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2024-07-24 15:39:00 Re: Detect buffer underflow in get_th()
Previous Message Peter Eisentraut 2024-07-24 15:33:07 Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx