Re: Any reason to have heap_(de)formtuple?

Kris Jurka napsal(a):
>
>
> On Thu, 23 Oct 2008, Kris Jurka wrote:
>
>> The problem with trying to deprecate it is that the vast majority of
>> the backend is still using the old interfaces, so people looking for
>> inspiration for their external modules will likely end up using the
>> old interface. Like Alvaro I started this conversion a while ago, got
>> bored, and forgot about it. If people do want this conversion done
>> while keeping the old interface around, I can track down that patch,
>> update it and finish it up for the next CommitFest.
>>
>
> Here's a patch that changes everything over to the the new API and
> implements the old API by calling the new API.

It seems to me OK. I have only one comment. I prefer to pfree allocated memory
for temporary nulls array. I think that caller could call old API many times
without memory context cleanup.

Zdenek

--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql