Re: jsonlog missing from logging_collector description

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Umar Hayat <postgresql(dot)wizard(at)gmail(dot)com>
Cc: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: jsonlog missing from logging_collector description
Date: 2025-01-31 15:19:29
Message-ID: 3774947.1738336769@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Umar Hayat <postgresql(dot)wizard(at)gmail(dot)com> writes:
> On Fri, 31 Jan 2025 at 20:41, Ashutosh Bapat
> <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
>> - gettext_noop("Start a subprocess to capture stderr output and/or
>> csvlogs into log files."),
>> + gettext_noop("Start a subprocess to capture stderr, csvlog and/or
>> jsonlog into log files."),
>>
>> Did you remove the word "output" intentionally? It is related to
>> stderr and not jsonlog. I think, stderr usually refers to a file or a
>> file descriptor hence we added word "output" there. I wouldn't touch
>> it.

> Yes, It was omitted intentionally to match the wording in
> postgresql.conf.sample and documentation of logging_collector.

FWIW, it seems weird to me to use the word "output" with only one
of those terms. The proposed new wording is fine by me, or we
could do

"Start a subprocess to capture stderr, csvlog and/or jsonlog output
into log files."

I read that as 'stderr, csvlog and/or jsonlog' all being modifiers
for 'output', which is sensible grammar.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2025-01-31 15:24:58 Re: postgresql.conf.sample ordering for IO, worker related GUCs
Previous Message Daniel Gustafsson 2025-01-31 14:54:45 Re: Windows: openssl & gssapi dislike each other