| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Umar Hayat <postgresql(dot)wizard(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: jsonlog missing from logging_collector description |
| Date: | 2025-02-01 02:20:55 |
| Message-ID: | Z52FByct4HJeWiGb@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 31, 2025 at 10:19:29AM -0500, Tom Lane wrote:
> FWIW, it seems weird to me to use the word "output" with only one
> of those terms. The proposed new wording is fine by me, or we
> could do
>
> "Start a subprocess to capture stderr, csvlog and/or jsonlog output
> into log files."
>
> I read that as 'stderr, csvlog and/or jsonlog' all being modifiers
> for 'output', which is sensible grammar.
FWIW, I'd choose for keeping things simpler and just remove the word
"output", keeping this list as all the possible values. Hence, the
patch is OK here:
- gettext_noop("Start a subprocess to capture stderr output and/or csvlogs into log files."),
+ gettext_noop("Start a subprocess to capture stderr, csvlog and/or jsonlog into log files."),
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-02-01 02:32:42 | Re: jsonlog missing from logging_collector description |
| Previous Message | Masahiko Sawada | 2025-02-01 00:34:52 | Re: Make COPY format extendable: Extract COPY TO format implementations |