Re: Windows: openssl & gssapi dislike each other

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Dave Page <dpage(at)pgadmin(dot)org>, Imran Zaheer <imran(dot)zhir(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Windows: openssl & gssapi dislike each other
Date: 2025-01-31 14:54:45
Message-ID: 160E6A25-8BF6-4378-A3FF-3F9B0D266A45@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 24 Jan 2025, at 22:45, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> On 24 Jan 2025, at 21:07, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> On 2025-01-22 We 4:25 AM, Dave Page wrote:
>
>>> Anyway, no fix was committed as far as I know. I would suggest it should be back-patched as well.
>>
>> I'm quite partial to the approach suggested upthread by Andres (a separate pg_gssapi.h file). If there's agreement on that I'm prepared to go and make it happen, unless Daniel beats me to it. Backpatching also seems reasonable.
>
> Thanks for the reminder, I also agree that Andres' suggestion is the best
> option. I hacked up a patch but got distracted by the pgcrypto GUC patch for a
> bit. I'll share what I have once I've done a little testing.

After another (conference induced) distraction I remembered this thread again
and tested to build/test the patch against a GSSAPI enabled tree. I think this
is along the right lines.

--
Daniel Gustafsson

Attachment Content-Type Size
v1-0001-Move-GSSAPI-includes-into-its-own-header.patch application/octet-stream 4.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-01-31 15:19:29 Re: jsonlog missing from logging_collector description
Previous Message Melanie Plageman 2025-01-31 14:50:03 Re: EvictUnpinnedBuffer and buffer free list