Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-05 23:30:14
Message-ID: 20200305233014.GA2501@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
> Looks like you changed 65535 -> 65536 before commit. I checked the original
> patch and it has 65535.

That's my fault, thanks. I have been playing with the surroundings
while looking at your patch.

> Bit of a bummer that this passed make check-world, but the pgBackRest tests
> definitely did not like it.

Is that because you have a copy of this routine in your code?
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2020-03-06 00:14:20 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Previous Message Michael Paquier 2020-03-05 23:26:33 pgsql: Fix page-level checksum calculation in checksum_impl.h