Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-06 00:34:56
Message-ID: 8ea10012-50bc-5770-8882-622721e45194@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 3/5/20 6:30 PM, Michael Paquier wrote:
> On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
>
>> Bit of a bummer that this passed make check-world, but the pgBackRest tests
>> definitely did not like it.
>
> Is that because you have a copy of this routine in your code?

Yes, we pull this file into pgBackRest for our checksum validation. We
also do unit and integration tests against it.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-03-06 00:37:59 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Previous Message David Steele 2020-03-06 00:32:59 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h