| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Date: | 2020-03-06 00:37:59 |
| Message-ID: | 20200306003759.GA52814@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Mar 05, 2020 at 07:32:59PM -0500, David Steele wrote:
> FWIW, we use static values in our unit tests (which are written in C), then
> test against packaged versions of Postgres for integration tests.
>
> When I saw the commit I pulled it in so I could remove instructions for the
> manual step to add the cast. So in this case the issue was apparent really
> quickly. Normally we only pull in new code from PostgreSQL once a year.
>
> We think our unit tests against static values may have endianess issues but
> we have not verified that one way or the other. Here's what they look like:
>
> https://github.com/pgbackrest/pgbackrest/blob/e55443c890181ea63a350275447885331c8254e4/test/src/module/postgres/interfaceTest.c#L182
By doing so, the tests still fail if the page size is something else
than 8k, no?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2020-03-06 00:39:59 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Previous Message | David Steele | 2020-03-06 00:34:56 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |