Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: David Steele <david(at)pgmasters(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-05 17:51:50
Message-ID: 1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi Michael,

On 3/5/20 12:13 AM, Michael Paquier wrote:
> Avoid -Wconversion warnings when using checksum_impl.h
>
> This does not matter much when compiling Postgres proper as many
> warnings exist when enabling this compilation flag, but it can be
> annoying for external modules willing to use both.

Looks like you changed 65535 -> 65536 before commit. I checked the
original patch and it has 65535.

Bit of a bummer that this passed make check-world, but the pgBackRest
tests definitely did not like it.

Thanks,
--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Magnus Hagander 2020-03-05 18:08:33 Re: pgsql: Revert "initdb: Change authentication defaults"
Previous Message Alvaro Herrera 2020-03-05 14:55:28 pgsql: Remove RangeIOData->typiofunc