Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: Andres Freund <andres(at)anarazel(dot)de>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-06 19:16:55
Message-ID: 20200306191655.gm7hjex5c7znmomr@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2020-03-05 12:51:50 -0500, David Steele wrote:
> On 3/5/20 12:13 AM, Michael Paquier wrote:
> > Avoid -Wconversion warnings when using checksum_impl.h
> >
> > This does not matter much when compiling Postgres proper as many
> > warnings exist when enabling this compilation flag, but it can be
> > annoying for external modules willing to use both.
>
> Looks like you changed 65535 -> 65536 before commit. I checked the original
> patch and it has 65535.

I gotta say, that's something that just shouldn't happen.

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-06 19:17:56 pgsql: Allow Unicode escapes in any server encoding, not only UTF-8.
Previous Message Tom Lane 2020-03-06 17:19:41 pgsql: Allow ALTER TYPE to change some properties of a base type.