pgsql: Allow ALTER TYPE to change some properties of a base type.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow ALTER TYPE to change some properties of a base type.
Date: 2020-03-06 17:19:41
Message-ID: E1jAGdR-0000c9-Os@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow ALTER TYPE to change some properties of a base type.

Specifically, this patch allows ALTER TYPE to:
* Change the default TOAST strategy for a toastable base type;
* Promote a non-toastable type to toastable;
* Add/remove binary I/O functions for a type;
* Add/remove typmod I/O functions for a type;
* Add/remove a custom ANALYZE statistics functions for a type.

The first of these can be done by the type's owner; all the others
require superuser privilege since misuse could cause problems.

The main motivation for this patch is to allow extensions to
upgrade the feature sets of their data types, so the set of
alterable properties is biased towards that use-case. However
it's also true that changing some other properties would be
a lot harder, as they get baked into physical storage and/or
stored expressions that depend on the type.

Along the way, refactor GenerateTypeDependencies() to make it easier
to call, refactor DefineType's volatility checks so they can be shared
by AlterType, and teach typcache.c that it might have to reload data
from the type's pg_type row, a scenario it never handled before.
Also rearrange alter_type.sgml a bit for clarity (put the
composite-type operations together).

Tomas Vondra and Tom Lane

Discussion: https://postgr.es/m/20200228004440.b23ein4qvmxnlpht@development

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fe30e7ebfa3846416f1adeb7cf611006513a4ee0

Modified Files
--------------
doc/src/sgml/catalogs.sgml | 28 +-
doc/src/sgml/ref/alter_type.sgml | 155 ++++++++--
src/backend/catalog/pg_type.c | 45 ++-
src/backend/commands/typecmds.c | 490 ++++++++++++++++++++++++++----
src/backend/nodes/copyfuncs.c | 14 +
src/backend/nodes/equalfuncs.c | 12 +
src/backend/parser/gram.y | 21 +-
src/backend/tcop/utility.c | 13 +
src/backend/utils/cache/typcache.c | 158 +++++++---
src/bin/psql/tab-complete.c | 2 +-
src/include/catalog/pg_type.h | 4 +-
src/include/commands/typecmds.h | 2 +
src/include/nodes/nodes.h | 1 +
src/include/nodes/parsenodes.h | 13 +-
src/include/utils/typcache.h | 2 +
src/test/regress/expected/create_type.out | 78 +++++
src/test/regress/sql/create_type.sql | 57 ++++
17 files changed, 958 insertions(+), 137 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-03-06 19:16:55 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Previous Message Michael Paquier 2020-03-06 02:10:25 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h