Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-06 02:10:25
Message-ID: 20200306021025.GG52814@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Mar 05, 2020 at 08:20:23PM -0500, David Steele wrote:
> Couldn't we use pageinspect?

Oh, indeed. I forgot that we already have this function. The tests
of page.sql don't care about the page size either, so it would be
enough to add a couple of calls with some hardcoded bytea input.
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-06 17:19:41 pgsql: Allow ALTER TYPE to change some properties of a base type.
Previous Message David Steele 2020-03-06 01:20:23 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h