| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Date: | 2020-03-06 01:20:23 |
| Message-ID: | d9ec273a-7f94-db59-fc16-802357e1d23f@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 3/5/20 8:10 PM, Michael Paquier wrote:
> On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
>> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
>> one of the main reasons that we only support the default.
>
> Doing something is not complicated, now how would people like to do
> it? Here are the options I can think of:
> 1) A TAP test, which bypasses the tests if the page size is not 8k.
> 2) A test for src/test/regress/, with a method similar to what we do
> for collate.sql for the compilations without ICU.
>
> In both cases mentioned here, we would need a SQL function to handle
> the work.
Couldn we use pageinspect?
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-03-06 02:10:25 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Previous Message | Michael Paquier | 2020-03-06 01:10:06 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |