Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: David Steele <david(at)pgmasters(dot)net>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: 2020-03-06 01:10:06
Message-ID: 20200306011006.GC52814@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Mar 05, 2020 at 07:58:50PM -0500, David Steele wrote:
> Yeah, keeping BLKSZ a constant is pretty important for performance. That's
> one of the main reasons that we only support the default.

Doing something is not complicated, now how would people like to do
it? Here are the options I can think of:
1) A TAP test, which bypasses the tests if the page size is not 8k.
2) A test for src/test/regress/, with a method similar to what we do
for collate.sql for the compilations without ICU.

In both cases mentioned here, we would need a SQL function to handle
the work.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Steele 2020-03-06 01:20:23 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Previous Message David Steele 2020-03-06 00:58:50 Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h