| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Date: | 2020-03-06 00:14:20 |
| Message-ID: | CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Thu, Mar 5, 2020 at 3:30 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Thu, Mar 05, 2020 at 12:51:50PM -0500, David Steele wrote:
> > Looks like you changed 65535 -> 65536 before commit. I checked the original
> > patch and it has 65535.
>
> That's my fault, thanks. I have been playing with the surroundings
> while looking at your patch.
:/
That's a pretty dangerous mistake, and moreso because we don't have a
test around it. We should really find a way to add such a test -- just
a hardcoded page calculation that should always return the same value
perhaps?
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Steele | 2020-03-06 00:32:59 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |
| Previous Message | Michael Paquier | 2020-03-05 23:30:14 | Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h |