| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use of access(X_OK) check in pg_upgrade |
| Date: | 2011-05-18 16:13:58 |
| Message-ID: | 201105181613.p4IGDw719425@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian wrote:
> I broke the Win32 build members by using access(X_OK) in pg_upgrade. I
> have a fix for this but looking at pg_upgrade's exec.c, I see for
> Win32:
>
> if ((buf.st_mode & S_IXUSR) == 0)
>
> I am confused why Windows supports S_IXUSR but not X_OK.
I have applied the attached patch to fix this.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/pg_upgrade | text/x-diff | 797 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David E. Wheeler | 2011-05-18 16:15:50 | Re: deprecating contrib for PGXN |
| Previous Message | Magnus Hagander | 2011-05-18 16:12:48 | Re: Use of access(X_OK) check in pg_upgrade |