Re: Use of access(X_OK) check in pg_upgrade

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use of access(X_OK) check in pg_upgrade
Date: 2011-05-18 16:12:48
Message-ID: BANLkTinpy6bUcuzKBOCGQhJWXke+s+nm0w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, May 18, 2011 at 11:41, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> I broke the Win32 build members by using access(X_OK) in pg_upgrade.  I
> have a fix for this but looking at pg_upgrade's exec.c, I see for
> Win32:
>
>            if ((buf.st_mode & S_IXUSR) == 0)
>
> I am confused why Windows supports S_IXUSR but not X_OK.

It doesn't natively - we define it in port/win32.h

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-05-18 16:13:58 Re: Use of access(X_OK) check in pg_upgrade
Previous Message Noah Misch 2011-05-18 15:52:16 Re: switch UNLOGGED to LOGGED