Use of access(X_OK) check in pg_upgrade

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Use of access(X_OK) check in pg_upgrade
Date: 2011-05-18 15:41:51
Message-ID: 201105181541.p4IFfpL11199@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I broke the Win32 build members by using access(X_OK) in pg_upgrade. I
have a fix for this but looking at pg_upgrade's exec.c, I see for
Win32:

if ((buf.st_mode & S_IXUSR) == 0)

I am confused why Windows supports S_IXUSR but not X_OK.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2011-05-18 15:52:16 Re: switch UNLOGGED to LOGGED
Previous Message Stefan Kaltenbrunner 2011-05-18 15:38:27 Re: deprecating contrib for PGXN