Re: [PATCH] Move 'long long' check to c.h

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Move 'long long' check to c.h
Date: 2010-05-24 19:11:32
Message-ID: 201005242111.32622.meskes@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> I think the current coding is extremely fragile (if it indeed works at
> all) because of its assumption that <limits.h> has been included

Well, this is the case in the code so far.

> already. In any case, we have configure tests that exist only for the
> benefit of contrib modules, so it's hard to argue that we shouldn't have
> one that exists only for ecpg.
>
> I think we should fix this (properly) for 9.0.

Ok, I don't mind fixing it properly for 9.0. Will do so as soon as I find time.

Michael

--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ 179140304, AIM/Yahoo/Skype michaelmeskes, Jabber meskes(at)jabber(dot)org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2010-05-24 19:12:09 Re: Exposing the Xact commit order to the user
Previous Message Bruce Momjian 2010-05-24 19:11:28 Re: pg_upgrade docs