Re: [PATCH] Move 'long long' check to c.h

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Move 'long long' check to c.h
Date: 2010-05-24 19:20:14
Message-ID: 20100524192014.GH21875@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Michael Meskes (meskes(at)postgresql(dot)org) wrote:
> > I think the current coding is extremely fragile (if it indeed works at
> > all) because of its assumption that <limits.h> has been included
>
> Well, this is the case in the code so far.

Right, the existing code is after limits.h is included, my suggestion to
put it in c.h would have lost limits.h and broken things. Sorry about
that. I didn't realize the dependency and make check didn't complain
(not that I'm sure there's even a way we could have a regression test
for this..). I didn't intend to imply the currently-committed code
didn't work (I figured it was probably fine :), was just trying to tidy
a bit.

Thanks!

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Hunsberger 2010-05-24 19:30:52 Re: Hiding data in postgresql
Previous Message Robert Haas 2010-05-24 19:16:28 Re: pg_upgrade docs