Re: [HACKERS] Re: datetime regress test busted by incomplete checkin

From: Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>
To: phd2(at)earthling(dot)net
Cc: tgl(at)sss(dot)pgh(dot)pa(dot)us, hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Date: 1999-01-25 16:00:04
Message-ID: 199901251600.LAA20462@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hi!
>
> On Mon, 25 Jan 1999, Bruce Momjian wrote:
> > You need to patch datetime.sql too. That is required to generate the
> > proper expected file, which is compared to the out file. Can you supply
> > the patch?
>
> But it is here - 20 lines below from the beginning of the patch. The
> patch was generated by make_diff tools. Isn't it enough?

Got it. I am a dope. I will apply it as soon as I apply my current
aggregate work.

>
> > > *** ./src/test/regress/expected/datetime.out.orig Mon Jan 5 06:35:27 1998
> > > --- ./src/test/regress/expected/datetime.out Wed Jan 6 12:50:50 1999
> > > ***************
> > > *** 28,33 ****
> > > --- 28,40 ----
> > > @ 0
> > > (1 row)
> > >
> > > + QUERY: SET DateStyle = 'Postgres,noneuropean';
> > > + QUERY: SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> > > + Jan_01_1994_11am
> > > + ----------------------------
> > > + Sat Jan 01 11:00:00 1994 PST
> > > + (1 row)
> > > +
> > > QUERY: CREATE TABLE DATETIME_TBL( d1 datetime);
> > > QUERY: INSERT INTO DATETIME_TBL VALUES ('current');
> > > QUERY: INSERT INTO DATETIME_TBL VALUES ('today');
> > > *** ./src/test/regress/sql/datetime.sql.orig Sat Nov 15 05:55:57 1997
> > > --- ./src/test/regress/sql/datetime.sql Wed Jan 6 12:49:23 1999
> > > ***************
> > > *** 10,15 ****
> > > --- 10,18 ----
> > > SELECT ('current'::datetime = 'now'::datetime) as "True";
> > > SELECT ('now'::datetime - 'current'::datetime) AS "ZeroSecs";
> > >
> > > + SET DateStyle = 'Postgres,noneuropean';
> > > + SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> > > +
> > > CREATE TABLE DATETIME_TBL( d1 datetime);
> > >
> > > INSERT INTO DATETIME_TBL VALUES ('current');
>
> Oleg.
> ----
> Oleg Broytmann http://members.tripod.com/~phd2/ phd2(at)earthling(dot)net
> Programmers don't die, they just GOSUB without RETURN.
>
>

--
Bruce Momjian | http://www.op.net/~candle
maillist(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Broytmann 1999-01-25 16:10:02 Re: [HACKERS] Re: datetime regress test busted by incomplete checkin
Previous Message Thomas G. Lockhart 1999-01-25 15:55:12 Re: [HACKERS] Re: datetime regress test busted by incomplete checkin