| From: | "Thomas G(dot) Lockhart" <lockhart(at)alumni(dot)caltech(dot)edu> |
|---|---|
| To: | phd2(at)earthling(dot)net |
| Cc: | Bruce Momjian <maillist(at)candle(dot)pha(dot)pa(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [HACKERS] Re: datetime regress test busted by incomplete checkin |
| Date: | 1999-01-25 15:55:12 |
| Message-ID: | 36AC93E0.C48F681@alumni.caltech.edu |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Probably that's me. The patch attached. Is there any problem?
Could you phrase the query in the same style as most of the other tests
(a style we inherited from the original sources), where the first column
is a select of an empty string with the table count as the label? I
would suggest something like:
SELECT '' AS one,
datetime('1994-01-01', '11:00') AS "Sat Jan 01 11:00:00 1994 PST";
I think we can use the actual current result in the result label (and
without underscores), since you are surrounding it with double quotes
anyway.
TIA
- Tom
> + QUERY: SET DateStyle = 'Postgres,noneuropean';
> + QUERY: SELECT datetime('1994-01-01', '11:00') AS "Jan_01_1994_11am";
> + Jan_01_1994_11am
> + ----------------------------
> + Sat Jan 01 11:00:00 1994 PST
> + (1 row)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 1999-01-25 16:00:04 | Re: [HACKERS] Re: datetime regress test busted by incomplete checkin |
| Previous Message | Tom Lane | 1999-01-25 15:51:02 | Re: [HACKERS] Another source of snprintf/vsnprintf code |